Has one translations #2200
Merged
Has one translations #2200
+149
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablobm
force-pushed
the
has-one-translations
branch
from
423a714 to
bf9351f
Compare
pablobm
force-pushed
the
has-one-translations
branch
2 times, most recently
from
3037f03 to
03f5102
Compare
nickcharlton
approved these changes
Aug 11, 2022
|
@nickcharlton I think this is ready now. That was tricky! 😓 There has to be a better way to test this stuff... |
|
Yeah, they're pretty rough! I didn't even know where to start when I tried myself! |
The template `app/views/fields/has_one/_show.html.erb` wasn't using the correct i18n key to translate the field names of the associated record. This PR includes a heavy revamp of `spec/administrate/views/fields/has_one/_show_spec.rb`, which needed some TLC in order to work with it. The diff for `lib/administrate/field/associative.rb` looks a bit misleading. The actual change is the definition of associated_class_name is now above the private declaration. Fixes thoughtbot#2185
nickcharlton
force-pushed
the
has-one-translations
branch
from
03f5102 to
ef823b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2185.
The template
app/views/fields/has_one/_show.html.erbwasn't using the correct i18n key to translate the field names of the associated record.This PR includes a heavy revamp of
spec/administrate/views/fields/has_one/_show_spec.rb, which needed some TLC in order to work with it.The diff for
lib/administrate/field/associative.rblooks a bit misleading. The actual change is that I moved the definition ofassociated_class_nameto be above theprivatedeclaration.